Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(vagrant): Use cross to build pulsar #196

Merged
merged 1 commit into from
Sep 2, 2023
Merged

chore(vagrant): Use cross to build pulsar #196

merged 1 commit into from
Sep 2, 2023

Conversation

vadorovsky
Copy link
Member

This way we don't require having the musl toolchain installed on host.

banditopazzo
banditopazzo approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@banditopazzo banditopazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right!! just update the comment above that cross is required instead of musl toolchain

@vadorovsky
chore(vagrant): Use cross to build pulsar
295ef15 
This way we don't require having the musl toolchain installed on
host.
@vadorovsky
Copy link
Member Author

@banditopazzo Good point, done!

@vadorovsky vadorovsky merged commit c4c9c34 into exein-io:main Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banditopazzo banditopazzo banditopazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vadorovsky @banditopazzo