[40] Build SMTP Integration For Threats Logging

[azenna]

Build SMTP Integration for threats logging

Adds a smtp notifier module that sends email on threats. Uses mail-sender library for convenience, could write inhouse smtp-client if necessary.

I have

• run cargo fmt;
• run cargo clippy;
• run cargo testand all tests pass;
• linked to the originating issue (if applicable).

resolves #40

[vadorovsky]

Thanks for your contribution! The code in general looks good, I left few minor comments.

[vadorovsky]

Hmm... can we double-check whether we really need the full set of features? Maybe it's possible to use just specific ones?

[vadorovsky]

The CI failure seems legit - the ring crate fails to build on riscv. We need to make sure we don't build it for riscv. I will think of solutions and let you know of I have any ideas, but feel free to also look for solutions. :)

[azenna]

Hmm I think these can maybe be fixed by adding libsssl-dev to the CI. Thoughts?

[banditopazzo]

Hi, I think a better solution is to use lettre, it's a more advanced crate. by default it uses openssl instead of rustls, so it should compile on riscv64

[banditopazzo]

you should also add port in the configuration and an option for the encryption, something like:

enum Encryption {
     Plain,
     TLS,
     StartTLS
}

[banditopazzo]

you need to add libssl-dev in dockerfiles under .cross, not in the github workflow and expose a openssl-vendored feature for musl builds

[azenna]

Got everything building 🎉 Added the tls and port configuration options as well

[vadorovsky]

Looks great, thanks! I will let @banditopazzo to give a final approval

[banditopazzo]

the main issue is the fixed vendored feature of openssl: in normal cases openssl should be dynamically linked with the option to link it statically, for example with musl. this should be under a feature and the feature should be re-exported by pulsar binary.
I added few suggestions to cross containers and tomls but needs to double checked.

the workflows need to be modified for musl builds adding an extra feature openssl-vendored

[banditopazzo]

the .from in the builder should be optional. for many email providers it's not possible to change the sender because of authentication implications and some of them don't require it to be set

[azenna]

the main issue is the fixed vendored feature of openssl: in normal cases openssl should be dynamically linked with the option to link it statically, for example with musl. this should be under a feature and the feature should be re-exported by pulsar binary. I added few suggestions to cross containers and tomls but needs to double checked.

the workflows need to be modified for musl builds adding an extra feature openssl-vendored

Couldn't figure out how to pass a --feature arg to cross from the CI, but did find an alternative using platform specific dependencies targeting target_env: musl, gnu

[banditopazzo]

#202 is merged, please rebase on main to check if the ci passes after those changes

[banditopazzo]

Few minor changes are necessary, I will make a fix after this is merged