Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add listen event and exec arguments #69

Merged
merged 5 commits into from
Oct 10, 2022
Merged

Add listen event and exec arguments #69

merged 5 commits into from
Oct 10, 2022

Conversation

MatteoNardi
Copy link
Contributor

This implements #65 and #66

I'm not particularly happy about the performance implications of the arguments modification.

  1. We're copying much data on every event to userspace, even if the arguments are smaller.
    We should optimize these by using some variable size data structure.

  2. We're cloning the arguments when getting info from process tracker https://github.com/Exein-io/pulsar/blob/c39136b3ad8862cb1882833fec2d78bbba958df7/pulsar-core/src/pdk/process_tracker.rs#L269
    Even when most of the times we'll discard them: https://github.com/Exein-io/pulsar/blob/c39136b3ad8862cb1882833fec2d78bbba958df7/pulsar-core/src/pdk/module.rs#L184-L191
    We could (A) add a different method, complicating the API or (B) use an Arc. What do you think?

I have

  • run cargo fmt;
  • run cargo clippy;
  • run cargo testand all tests pass;
  • linked to the originating issue (if applicable).

Base automatically changed from probe_links to main October 6, 2022 16:00
modules/process-monitor/probes.bpf.c Show resolved Hide resolved
pulsar-core/src/pdk/process_tracker.rs Outdated Show resolved Hide resolved
Remove the unneeded unroll directive.
Replace non-CORE probe_read calls, with CORE enabled ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants