Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resistor-color-duo #262

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

BNAndras
Copy link
Sponsor Member

@BNAndras BNAndras commented Sep 9, 2024

Towards #223

I used an enum here so resistor-color and resistor-color-trio should also use similar enums for consistency. The intention is that a student works through these three exercises as a group, unlocking more complexity along the way.

Some tracks omit the test about ignoring additional colors. Exercism as a whole doesn't make a big deal of input validation except for a few specific exercises. If we choose to not include the test, then we can use two Color parameters instead of the array.

@0xNeshi
Copy link
Contributor

0xNeshi commented Sep 9, 2024

We can include the test (as is implemented)

@0xNeshi 0xNeshi merged commit be283bd into exercism:main Sep 9, 2024
5 checks passed
@BNAndras BNAndras deleted the add-resistor-color-duo branch September 9, 2024 15:09
@BNAndras
Copy link
Sponsor Member Author

BNAndras commented Sep 9, 2024

Before I forget, I noticed you put x:size labels on the issues for adding the PRs. x:size is soft deprecated in favor of x:rep for clarity's sake, but they'll still work for adjusting the reputation awarded to a particular PR. Those labels do need to also be added to the PR directly though. https://exercism.org/docs/using/product/reputation#h-creating-a-pull-request has some examples of when you might use the different labels, but it's purely optional. An unlabeled PR is worth the same rep as a x:rep/medium / x:size/medium PR.

@0xNeshi
Copy link
Contributor

0xNeshi commented Sep 9, 2024

Thx for the tips!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants