Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prime_factors & nth_prime #282

Merged
merged 50 commits into from
Sep 23, 2024
Merged

prime_factors & nth_prime #282

merged 50 commits into from
Sep 23, 2024

Conversation

Falilah
Copy link
Contributor

@Falilah Falilah commented Sep 16, 2024

Closes #205
Closes #215

Copy link

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

@Falilah Falilah changed the title prime_factors prime_factors & nth_prime Sep 19, 2024
@0xNeshi
Copy link
Contributor

0xNeshi commented Sep 20, 2024

Hi, thanks for the PR! Will be taking a look later in the day

Copy link
Contributor

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job! Left some relatively minor comments, we can merge immediately after those are addressed

exercises/practice/nth-prime/.meta/example.cairo Outdated Show resolved Hide resolved
exercises/practice/nth-prime/src/lib.cairo Outdated Show resolved Hide resolved
exercises/practice/prime-factors/.meta/example.cairo Outdated Show resolved Hide resolved
Copy link
Contributor

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work!

@0xNeshi 0xNeshi merged commit 6e1aa6e into exercism:main Sep 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Practice Exercise: prime-factors Add Practice Exercise: nth-prime
2 participants