Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test command to Shell completions #1156

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

muzimuzhi
Copy link
Contributor

@muzimuzhi muzimuzhi commented Aug 18, 2024

test command was supported since v3.2.0, see a8ffc31 (Add test command to run any unit test (#1092), 2023-07-28)

I hesitate to also add prepare command (see ./cmd/prepare.go@b43bd372) to completions, because it seems it's no longer an everyday command. The default completion command created by cobra is also not added, see my topic on the Exercism Forum.

`test` command was supported since v3.2.0, see
a8ffc31 (Add `test` command to run any unit test (\exercism#1092), 2023-07-28)
Copy link

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Aug 18, 2024
@ErikSchierboom ErikSchierboom merged commit 20d58b1 into exercism:main Aug 20, 2024
8 checks passed
@muzimuzhi muzimuzhi deleted the test-cmd-completion branch August 22, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants