Create exercism directory on configuration #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to keep all the writes isolated to the handlers. Let's add the code that writes the directory directly to the |
|
OK, just so I'm clear, you want me to remove the function that writes the directory out of the |
Tonkpils
force-pushed
the
create-directory
branch
from
3335bee
to
ec4de74
Compare
|
Yepp, thanks! |
kytrinyx
added a commit
that referenced
this pull request
Oct 12, 2014
Create exercism directory on configuration
lcowell
pushed a commit
to lcowell/cli
that referenced
this pull request
Jan 25, 2015
Create exercism directory on configuration
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't really sure where to place the logic to create the directory. Initially, I had planned to put it under
configure()but that gets called when reading the contents of the file. It also seems like errors coming fromconfigure()don't get checked but this is an error we'd generally want to display.I decided to go for creating an exported function of Config and calling it before writing the file so that the file does not have a directory that could not be created. Let me know if anything jumps out.
Fixes #122