Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't accept token flag on download command #631

Merged
merged 5 commits into from
Jul 14, 2018
Merged

Commits on Jul 13, 2018

  1. Reorder tests for download command

    Put the helper methods and fixtures at the bottom of the file.
    Katrina Owen committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    90c726f View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2018

  1. Rename test helper for clarity and consistency

    The various command tests need different types of mock servers. These all live in the
    same namespace, despite being defined in different files.
    
    The download command test had a 'makeMockServer' function, which in the scope of
    the entire cmd package is not specific enough. This renames it to fakeDownloadServer
    which follows the pattern used in the submit test (fakeSubmitServer).
    
    I prefer that the name reflect _what it returns_ rather than _what you
    are asking it to do_. So for something that returns a _thing_, I'd
    rather it be named _thing_ than _make thing_.
    Katrina Owen committed Jul 14, 2018
    Configuration menu
    Copy the full SHA
    463a4ad View commit details
    Browse the repository at this point in the history
  2. Do not accept token flag on download command

    Katrina Owen committed Jul 14, 2018
    Configuration menu
    Copy the full SHA
    f230330 View commit details
    Browse the repository at this point in the history
  3. Complain if downloading without a configured token

    We need to know who you are in order to download the correct exercise with all the requisite
    metadata.
    
    Originally the download command allowed you to pass a token on the fly, during download.
    That added a lot of complexity, so instead we bail with a helpful error message
    that explains how to configure the client.
    Katrina Owen committed Jul 14, 2018
    Configuration menu
    Copy the full SHA
    7a201d4 View commit details
    Browse the repository at this point in the history
  4. Move duplicated welcome message to constant

    Katrina Owen committed Jul 14, 2018
    Configuration menu
    Copy the full SHA
    4d6f292 View commit details
    Browse the repository at this point in the history