Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leap 48in24 approaches #599

Merged
merged 10 commits into from
Jan 14, 2024
Merged

Conversation

michalporeba
Copy link
Contributor

This resolves #598

I propose an introduction to the approaches and specific approaches to the problem.
Considering the time until 48in24 I welcome early feedback on the text and the selection of the approaches.
I will work on specific approaches in subsequent commits.

I'd appreciate early feedback.

Copy link
Contributor

github-actions bot commented Jan 7, 2024

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 7, 2024
@iHiD iHiD reopened this Jan 13, 2024
@michalporeba michalporeba marked this pull request as ready for review January 13, 2024 19:58
@michalporeba
Copy link
Contributor Author

@iHiD thanks for offering to help.

The PR is ready for review/checks/merging. I took an approach similar to what I have done for Elixir, and on that track the approach to approaches went through a number of review cycles with Angelika. I hope the quality has rubbed off onto this PR.

I'd like to merge it today / early tomorrow so I can see how it looks, check the links and so on before possibly submitting another PR with any improvements necessary tomorrow afternoon.

I will be available from now until about mid-day tomorrow - a night shift - but if there is any feedback before the merge I will be working on it tomorrow early afternoon.

Again, thanks for the help.

@iHiD iHiD merged commit bf84d4d into exercism:main Jan 14, 2024
2 checks passed
@iHiD
Copy link
Member

iHiD commented Jan 14, 2024

Thanks so much! Merged. Follow up PRs from reviewers welcome :)

@michalporeba michalporeba deleted the leap-48in24-approaches branch January 15, 2024 11:32
@michalporeba michalporeba restored the leap-48in24-approaches branch January 18, 2024 21:10
@michalporeba michalporeba deleted the leap-48in24-approaches branch January 19, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leap 48in24 approaches
2 participants