Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

space-age: sync tests #786

Merged
merged 1 commit into from
Jan 21, 2025
Merged

space-age: sync tests #786

merged 1 commit into from
Jan 21, 2025

Conversation

ErikSchierboom
Copy link
Member

No description provided.

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs an update in the .tpl file (the last ~) ?

Also the space_age.clj file still has the old style function templates.

The functions all start with on- whereas in the tests they start with on_

@ErikSchierboom
Copy link
Member Author

All updated

Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ErikSchierboom ErikSchierboom merged commit 50563cf into main Jan 21, 2025
2 checks passed
@ErikSchierboom ErikSchierboom deleted the space-age branch January 21, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants