Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update library of luton and add new tag system #673

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

meatball133
Copy link
Member

In prep for: exercism/crystal-test-runner#85

Also allows to only run test for a certain test by just running crystal spec --tag task_id=x

Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@meatball133 meatball133 marked this pull request as draft July 14, 2024 22:34
| Method | Description |
| Method                           | Description                                          |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen this in a few of these PRs -- do you know what's actually different? At a glance it appears that the before and after are both spaces.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my editor might change something, I am not sure why.

@@ -36,8 +36,8 @@ There is also a method called [`Char#succ`][succ] which will return the next cha

## concatenation

Since Chars is only meant to represent a 32-bit Unicode, can't 2 chars be concatenation.
Thereby Chars can only be concatenated with Strings.
Since Chars is only meant to represent a 32-bit Unicode, can't two chars be concatenated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Since Chars is only meant to represent a 32-bit Unicode, can't two chars be concatenated.
Since Chars is only meant to represent a 32-bit Unicode, two chars can't be concatenated.

@@ -36,8 +36,8 @@ There is also a method called [`Char#succ`][succ] which will return the next cha

## concatenation

Since Chars is only meant to represent a 32-bit Unicode, can't 2 chars be concatenation.
Thereby Chars can only be concatenated with Strings.
Since Chars is only meant to represent a 32-bit Unicode, can't two chars be concatenated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Since Chars is only meant to represent a 32-bit Unicode, can't two chars be concatenated.
Since Chars is only meant to represent a 32-bit Unicode, two chars can't be concatenated.

@meatball133 meatball133 marked this pull request as ready for review August 7, 2024 09:01
@meatball133 meatball133 merged commit 680abe7 into exercism:main Aug 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants