Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync reverse-string tests #2293

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

BNAndras
Copy link
Sponsor Member

No description provided.

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure I'm in favor of this change. It would break all existing solutions. I think I'd rather prefer a separate Concept Exercise that explained Unicode and grapheme clusters.

@BNAndras
Copy link
Sponsor Member Author

BNAndras commented Aug 1, 2024

I'll revert the changes and just mark the Unicode tests as not included.

@ErikSchierboom ErikSchierboom merged commit 7140e04 into exercism:main Aug 2, 2024
3 checks passed
@ErikSchierboom
Copy link
Member

Thanks!

@BNAndras BNAndras deleted the sync-reverse-string-tests branch August 2, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants