Fix CultureInfo being overridden by user settings #2296
Conversation
`new CultureInfo(string name)` by default sets `useUserOverride` to true, which uses Windows user customized settings. This results in tests failed on some machines with customized date time format. Use `CultureInfo.GetCultureInfo(string name)` instead which gets the cached instance or create a new instance with `useUserOverride` set to false.
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
The F# track likely has the same mistake. Would you be willing to submit a PR to that too? |
|
CI is failing: |
Ledger exercise originally wants a mutable CultureInfo instance to edit its format. `CultureInfo.GetCultureInfo`` instead return a read-only instance. Thus, we just call `new CultureInfo(loc, false)` to not use windows setting.
|
Hi, I have fixed the issue with |
new CultureInfo(string name)by default setsuseUserOverridetotrue, which uses Windows user customized settings. This results in local tests failed on some machines with customized date time format. UseCultureInfo.GetCultureInfo(string name)instead which gets the cached instance or creates a new instance withuseUserOverrideset tofalse.