Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update instructions.md #1530

Closed
wants to merge 1 commit into from
Closed

Update instructions.md #1530

wants to merge 1 commit into from

Commits on Oct 5, 2024

  1. Update instructions.md 

    The description as is doesn't make sense. It states at function 2: "Store the default initial score in a module attribute. It will be needed again."

The reset function however simply resets to 0, and implementing so passes all tests. There's no module attribute needed, neither to be defined nor to be used at any point. The enforcement to use one when adding a player is either arbitrary or not properly reflected in the exercise structure as is.

This pull request provides the minimal needed rewording to avoid confusion, stating outright a default attribute shall be used for a reset value.
    @srcsintheta
    srcsintheta authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    e568b6f View commit details
    Browse the repository at this point in the history