Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configlet sync CI is broken #359

Closed
BNAndras opened this issue Apr 23, 2024 · 4 comments
Closed

Configlet sync CI is broken #359

BNAndras opened this issue Apr 23, 2024 · 4 comments
Labels
x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows)

Comments

@BNAndras
Copy link
Member

@ErikSchierboom, we have a GHA that regularly uses configlet to check for unsynced files at https://github.com/exercism/emacs-lisp/actions/workflows/configlet-sync.yml, but it's been broken for over a year due to rate limits. Is this something fixable?

@BNAndras BNAndras added the x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) label Apr 23, 2024
@ErikSchierboom
Copy link
Member

Maybe check the logs to see if https://github.com/exercism/emacs-lisp/blob/main/.github/workflows/configlet-sync.yml#L17-L23 does indeed do an authenticated request? Or else simulate that locally.

Looking at CI, it looks like what is failing is the issue creation. Maybe check if the authentication is working there? Or else try updating the workflow?

@fapdash
Copy link
Contributor

fapdash commented May 14, 2024

If we find a solution we should also fix it for the common-lisp track, which has the same job and issue: https://github.com/exercism/common-lisp/blob/c35edf8095e87c64b9c2f22ea08a2da7024a3411/.github/workflows/configlet-sync.yml

@kmarker1101
Copy link
Contributor

this may be a long standing issue with create-an-issue

JasonEtco/create-an-issue#142

@fapdash
Copy link
Contributor

fapdash commented Sep 4, 2024

Same error here. It seems to be triggered easily when using the "update_existing: true" parameter, so the search/issues endpoint is the one affected by the secondary rate limit.

JasonEtco/create-an-issue#142 (comment)

We probably could get rid of this setting as we're closing the issue each time.

fapdash added a commit that referenced this issue Sep 4, 2024
The job sometimes fails because we're hitting a rate limit.
Removing `update_existing: true` seems to the main culprit
for hitting the rate limit.

See JasonEtco/create-an-issue#142 (comment)

works on #359
BNAndras pushed a commit that referenced this issue Sep 4, 2024
The job sometimes fails because we're hitting a rate limit.
Removing `update_existing: true` seems to the main culprit
for hitting the rate limit.

See JasonEtco/create-an-issue#142 (comment)

works on #359
@BNAndras BNAndras closed this as completed Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows)
Projects
None yet
Development

No branches or pull requests

4 participants