-
-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated tests for the Custom Set problem #328
Labels
Comments
robphoenix
pushed a commit
to robphoenix/exercism-go
that referenced
this issue
Jan 17, 2017
updated tests for custom-set exercism#328 In the process of updating the tests I ended up simplifying(hopefully) the tests cases. I removed all the extra methods and functions including String which fundamentally changed the tests. I've also added a stub with only the Set type in it, so that the exercise focuses on the set operations rather than defining a set type. This also means that the set type is agreed up front and so there's no need to accomodate all possible types that people could come up with for a set by defining it with something like a string method. Also relevant for reference: exercism/problem-specifications#232 exercism/problem-specifications#257
robphoenix
pushed a commit
to robphoenix/exercism-go
that referenced
this issue
Jan 17, 2017
updated tests for custom-set exercism#328 In the process of updating the tests I ended up simplifying(hopefully) the tests cases. I removed all the extra methods and functions including String which fundamentally changed the tests. I've also added a stub with only the Set type in it, so that the exercise focuses on the set operations rather than how to define the set type. This also means that the set type is agreed up front and so there's no need to accomodate all possible types that people could come up with for a set by defining it with something like a string method. Also relevant for reference: exercism/problem-specifications#232 exercism/problem-specifications#257
robphoenix
pushed a commit
to robphoenix/exercism-go
that referenced
this issue
Jan 20, 2017
updated tests for custom-set exercism#328 for reference: exercism/problem-specifications#232 exercism/problem-specifications#257
robphoenix
pushed a commit
to robphoenix/exercism-go
that referenced
this issue
Jan 20, 2017
updated tests for custom-set exercism#328 for reference: exercism/problem-specifications#232 exercism/problem-specifications#257
robphoenix
pushed a commit
to robphoenix/exercism-go
that referenced
this issue
Jan 20, 2017
updated tests for custom-set exercism#328 for reference: exercism/problem-specifications#232 exercism/problem-specifications#257
robphoenix
pushed a commit
to robphoenix/exercism-go
that referenced
this issue
Jan 20, 2017
updated tests for custom-set exercism#328 for reference: exercism/problem-specifications#232 exercism/problem-specifications#257
robphoenix
pushed a commit
to robphoenix/exercism-go
that referenced
this issue
Jan 21, 2017
updated tests for custom-set exercism#328 for reference: exercism/problem-specifications#232 exercism/problem-specifications#257
robphoenix
pushed a commit
to robphoenix/exercism-go
that referenced
this issue
Jan 21, 2017
updated tests for custom-set exercism#328 for reference: exercism/problem-specifications#232 exercism/problem-specifications#257
closed by #454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In order to reduce the amount of code required to pass incremental tests (assuming that users pass tests starting from the top), the order of the tests was modified slightly.
Since this track implements Custom Set, please take a look at the new custom-set.json file and see if your track should update its tests.
If you do need to update your tests, please refer to this issue in your PR. That helps us see which tracks still need to update their tests.
If your track is already up to date, go ahead and close this issue.
More details on this change are available in exercism/problem-specifications#257.
The text was updated successfully, but these errors were encountered: