Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial POC of how to ignore all-but-first test #106

Merged
merged 1 commit into from
Sep 21, 2016
Merged

Initial POC of how to ignore all-but-first test #106

merged 1 commit into from
Sep 21, 2016

Conversation

sit
Copy link
Contributor

@sit sit commented Apr 1, 2016

Introduce a new JUnit test category that lets us mark certain tests as
not ready for execution. The test task in the individual project
can then be configured to not run tests marked as NotReady.

For the CI server builds, add a fullTest test task that simply runs
tests as normal, and link it into the check task so it runs on builds.

This is not perfect, as the class under test must still compile, so it
must have at least the correct signatures of all the methods tested.
Also, it may be worth finding a way to distribute the NotReady interface
that doesn't require checking it into every project.

This will fix #101.

Introduce a new JUnit test category that lets us mark certain tests as
not ready for execution. The test task in the individual project
can then be configured to not run tests marked as `NotReady`.

For the CI server builds, add a fullTest test task that simply runs
tests as normal, and link it into the check task so it runs on builds.

This is not perfect, as the class under test must still compile, so it
must have at least the correct signatures of all the methods tested.
Also, it may be worth finding a way to distribute the NotReady interface
that doesn't require checking it into every project.
@jtigger
Copy link
Contributor

jtigger commented Apr 1, 2016

Having an example to talk to is very helpful, @sit; thanks!

Chewing... :)

@jtigger
Copy link
Contributor

jtigger commented Apr 2, 2016

@sit do you have time to flesh this out? Otherwise, either @matthewmorgan or myself could do the grunt work.

@jtigger
Copy link
Contributor

jtigger commented Apr 11, 2016

@matthewmorgan and I are picking this one up. We agreed that @sit's approach is the way forward, here. Thanks!

@jtigger
Copy link
Contributor

jtigger commented Aug 31, 2016

Yikes! So sorry for squatting on this issue. :( Really want to see this implemented.

Recently, @matthewmorgan and I have been focusing on some amateur data science'ing, but perhaps we'll clear out some of these PRs and issues too.

@jtigger jtigger changed the base branch from master to ignore-all-but-first-test September 21, 2016 21:57
@jtigger jtigger merged commit 2b217ad into exercism:ignore-all-but-first-test Sep 21, 2016
@jtigger
Copy link
Contributor

jtigger commented Sep 21, 2016

Starting with Emil's (@sit) work. I'm hoping this will preserve history/blame/credit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants