Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tests of Bob exercise to sync with the Problem-Specification repo #2870

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

jagdish-15
Copy link
Contributor

Pull Request


Reviewer Resources:

Track Policies

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@jagdish-15
Copy link
Contributor Author

Hello @kahgoh,

The new test reimplements the old test but changes the position of the line break for questions with line breaks. I’m unsure whether this qualifies as [no important files changed]. Could you please share your thoughts on this?

@kahgoh
Copy link
Member

kahgoh commented Nov 19, 2024

I'd say no, it doesn't qualify because the new test has a different expected value.

@jagdish-15
Copy link
Contributor Author

Is there anything else that I should consider?

Copy link
Member

@kahgoh kahgoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the changes look good to me.

@kahgoh kahgoh added the x:size/small Small amount of work label Nov 19, 2024
@kahgoh kahgoh merged commit e6063fc into exercism:main Nov 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants