Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pangram: Diacritics and ligatures #1318

Closed
wants to merge 1 commit into from
Closed

Conversation

leNEKO
Copy link

@leNEKO leNEKO commented Sep 4, 2018

What about checking if it can handle diacritics and ligatures ? (é è ç œ ß …)

That could seem secondary, but that is a must for lot of languages that use more characters than the plain ASCII (French, Deutsch, Spanish, …)

What do you think ?

What about checking if it can handle diacritics and ligatures ? (é è ç œ ß …)

That could seem secondary, but that is a must for lot of languages that use more characters than the plain ASCII (French, Deutsch, Spanish, …)

What do you think ?
@petertseng
Copy link
Member

In similar vein, we used to have test with umlaut, and a test with Cyrillic. They were removed in #440 because #428. Same situation or different situation?

Please prefix PR title and commit message with exercise being affected, so it is possible to tell at a glance from git log and PR list https://github.com/exercism/problem-specifications/pulls . We have so many exercises that this becomes necessary to prefix.

@leNEKO leNEKO changed the title Diacritics and ligatures Pangram : Diacritics and ligatures Sep 4, 2018
@leNEKO leNEKO changed the title Pangram : Diacritics and ligatures Pangram: Diacritics and ligatures Sep 4, 2018
@leNEKO
Copy link
Author

leNEKO commented Sep 4, 2018

Oh that is strictly the same situation than in #428
I have read the discussion and can understand the PITA argument that lead to this decision as i undergo these issues on a day basis :)

In fact we can suggest this to students while mentoring their solutions, if we feel that is valuable,
but i wonder if we can set canonical test as "extra/optionnal/bonus" ?

@leNEKO leNEKO closed this Sep 4, 2018
@petertseng
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants