Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Json library to the dependencies #11

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

ageron
Copy link
Contributor

@ageron ageron commented Sep 9, 2024

The Json library is needed by the upcoming rest-api exercise

@ageron ageron requested a review from a team as a code owner September 9, 2024 01:53
@IsaacG
Copy link
Member

IsaacG commented Sep 9, 2024

Is there any way to confirm this doesn't significantly impact the image size?

@ageron
Copy link
Contributor Author

ageron commented Sep 9, 2024

Thanks for your review, @IsaacG
Regarding the size, these packages are pretty small, so it shouldn't be an issue.
What would be a problematic size? What problems could it cause?
We could add a GitHub Action to check the size?

@ageron ageron merged commit e4f9fc7 into exercism:main Sep 9, 2024
3 checks passed
@ageron ageron deleted the add-json-lib branch September 9, 2024 03:35
@IsaacG
Copy link
Member

IsaacG commented Sep 9, 2024

Regarding the size, these packages are pretty small, so it shouldn't be an issue.
What would be a problematic size? What problems could it cause?

If it's small, it should be fine. I have no idea what size they are. One of Exercism's larger costs is image storage.

@ageron
Copy link
Contributor Author

ageron commented Sep 9, 2024

Here are the sizes:

Package Download Decompressed
Roc 33.9M 95.5M
basic-cli platform 8.2M 45.3M
Unicode package 0.1M 1.2M
Json package 0.0M 0.1M
Isodate package 0.0M 0.1M

Literally 99% of the size is the absolute minimum we need to run Roc: the roc compiler + the basic-cli platform.
I'll chat with the Roc team to see if we can shrink that down somehow.

At least these numbers show that we can add a few more packages without having any significant impact.

@IsaacG
Copy link
Member

IsaacG commented Sep 9, 2024

Those sizes definitely sounds like they are completely fine!! Thank you for checking.

@ageron
Copy link
Contributor Author

ageron commented Sep 9, 2024

We're currently using the Ubuntu 24.04 base image, which looks like it's about 80M.

We're also using:

  • wget
  • jq
  • libc-dev
  • binutils

I'm not sure how to tell how big these packages and their dependencies are.

It might help to switch to Alpine as our base image, but right now Roc does not yet support it. It's work in progress, so when that's ready, we can switch and hopefully shrink the image a bit.

@IsaacG
Copy link
Member

IsaacG commented Sep 9, 2024

If you can switch to Alpine, that would be nice. But don't worry about it too much. Maybe tracks use Ubuntu images as they tend to be easier to work with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants