Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix CI #1654

Merged
merged 7 commits into from
Apr 11, 2024
Merged

Try to fix CI #1654

merged 7 commits into from
Apr 11, 2024

Conversation

ErikSchierboom
Copy link
Member

No description provided.

@ErikSchierboom
Copy link
Member Author

@kotp I've upgraded a bunch of stuff, but now I'm getting a different error. Would you mind looking into it?

@kotp
Copy link
Member

kotp commented Apr 6, 2024

Spent quite some time researching.

Without any success so far for a fix.

But pushing to see if the CI passes with this change...

@ErikSchierboom
Copy link
Member Author

It looks like that did fix some things, as we now only have the knapsack error:

running tests for: knapsack
/tmp/knapsack20240406-1977-30tzgx/knapsack_test.rb:5:in `class:KnapsackTest': uninitialized constant KnapsackTest::Data (NameError)

Item = Data.define(:weight, :value)
^^^^
from /tmp/knapsack20240406-1977-30tzgx/knapsack_test.rb:4:in `

'

@kotp
Copy link
Member

kotp commented Apr 9, 2024

It looks like that did fix some things,

The fix is mostly "less detail" or "less specific" so the behavior may not be what was intended when it was written.

as we now only have the knapsack error:

running tests for: knapsack
/tmp/knapsack20240406-1977-30tzgx/knapsack_test.rb:5:in `class:KnapsackTest': uninitialized constant KnapsackTest::Data (NameError)

Item = Data.define(:weight, :value) ^^^^ from /tmp/knapsack20240406-1977-30tzgx/knapsack_test.rb:4:in `

'

This is because of Data not being available for the version of Ruby. A separate issue, really. If you want to bring it in even with the Ruby 3.1 failing, I can definitely work a solution that will pass the Data not being available with that version. (While still using Data as it is when it is provided by the language.)

The `Data` class was introduced in Ruby 3.2.0

The class that is introduced here can be removed once our minimum
supported Ruby version is 3.2.0 or higher.
@kotp
Copy link
Member

kotp commented Apr 9, 2024

The last commit does fix the knapsack, I think, but fails for where Data is being used for the zebra exercise.

@ErikSchierboom
Copy link
Member Author

The last commit does fix the knapsack, I think, but fails for where Data is being used for the zebra exercise.

Any chance you could fix that too?

@kotp
Copy link
Member

kotp commented Apr 10, 2024

The last commit does fix the knapsack, I think, but fails for where Data is being used for the zebra exercise.

Any chance you could fix that too?

Ruby 3.0 has just transitioned to End of Life, Ruby 3.1 will be end of life in the next 11 months. Perhaps we make this "reportive" rather than required?

@ErikSchierboom
Copy link
Member Author

Ruby 3.0 has just transitioned to End of Life, Ruby 3.1 will be end of life in the next 11 months. Perhaps we make this "reportive" rather than required?

Let's just test on Ruby 3.2 and Ruby 3.3 then.

@ErikSchierboom ErikSchierboom merged commit 709c04c into main Apr 11, 2024
3 checks passed
@ErikSchierboom ErikSchierboom deleted the fix-ci branch April 11, 2024 06:11
@kotp
Copy link
Member

kotp commented Apr 11, 2024

Thank you @ErikSchierboom !

@ErikSchierboom
Copy link
Member Author

You too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants