-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to fix CI #1654
Try to fix CI #1654
Conversation
ca7d80d
to
7644481
Compare
@kotp I've upgraded a bunch of stuff, but now I'm getting a different error. Would you mind looking into it? |
Spent quite some time researching. Without any success so far for a fix. But pushing to see if the CI passes with this change... |
It looks like that did fix some things, as we now only have the knapsack error:
Item = Data.define(:weight, :value) |
The fix is mostly "less detail" or "less specific" so the behavior may not be what was intended when it was written.
This is because of |
The `Data` class was introduced in Ruby 3.2.0 The class that is introduced here can be removed once our minimum supported Ruby version is 3.2.0 or higher.
The last commit does fix the knapsack, I think, but fails for where Data is being used for the zebra exercise. |
Any chance you could fix that too? |
Ruby 3.0 has just transitioned to End of Life, Ruby 3.1 will be end of life in the next 11 months. Perhaps we make this "reportive" rather than required? |
Let's just test on Ruby 3.2 and Ruby 3.3 then. |
Thank you @ErikSchierboom ! |
You too! |
No description provided.