-
-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PrimeFactors: Replace for
with of
(for is a Ruby keyword)
#964
Conversation
for
with of
(for is a Ruby keyword)for
with of
(for is a Ruby keyword)
I agree, but there is going to need to be changes to the generator to put this into play. This hasn't been done yet, are you up for the task? Also, the solution file should be updated so the tests can pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generator could be put into place.
At minimum, the solution file needs to be changed to support the tests.
Fixed solution also. |
Think I would need a clearer hint than that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
"Need" was too strong a word, but it is good to put the generator into play as we make changes. Look to the generator section of the Readme for more details. |
🐫 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of
is probably a better name than for
but not because for
is a keyword.
Maybe partly because? :-) Anyways, thanks for approval. |
for
is a Ruby keyword, so this is just bad naming if you ask me.