Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrimeFactors: Replace for with of (for is a Ruby keyword) #964

Merged
merged 1 commit into from
Aug 31, 2019

Conversation

joshgoebel
Copy link
Contributor

for is a Ruby keyword, so this is just bad naming if you ask me.

@emcoding emcoding changed the title Replace for with of (for is a Ruby keyword) PrimeFactors: Replace for with of (for is a Ruby keyword) Jun 4, 2019
@kotp
Copy link
Member

kotp commented Jun 13, 2019

I agree, but there is going to need to be changes to the generator to put this into play. This hasn't been done yet, are you up for the task?

Also, the solution file should be updated so the tests can pass.

Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generator could be put into place.

At minimum, the solution file needs to be changed to support the tests.

@joshgoebel
Copy link
Contributor Author

Fixed solution also.

@joshgoebel
Copy link
Contributor Author

I agree, but there is going to need to be changes to the generator to put this into play.

Think I would need a clearer hint than that?

Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kotp
Copy link
Member

kotp commented Jun 13, 2019

"Need" was too strong a word, but it is good to put the generator into play as we make changes. Look to the generator section of the Readme for more details.

@kotp
Copy link
Member

kotp commented Jul 29, 2019

🐫

Copy link
Contributor

@Insti Insti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of is probably a better name than for but not because for is a keyword.

@joshgoebel
Copy link
Contributor Author

joshgoebel commented Aug 30, 2019

but not because for is a keyword.

Maybe partly because? :-) Anyways, thanks for approval.

@kotp kotp merged commit 2bcd80f into exercism:master Aug 31, 2019
@joshgoebel joshgoebel deleted the patch-1 branch September 25, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants