add a trailing whitespace lint #1174
Conversation
I could not figure out how to use `-or` with `find` and `-exec` so am only doing this for `.toml` files. It would be nice to do so for `.sh` files.
| @@ -74,7 +77,7 @@ jobs: | |||
|
|
|||
| # stolen from https://raw.githubusercontent.com/exercism/github-actions/main/.github/workflows/shellcheck.yml | |||
| shellcheck: | |||
| name: shellcheck internal tooling | |||
| name: shellcheck internal tooling lint | |||
There was a problem hiding this comment.
Renamed this for consistency. I should also rename our markdown_lint.sh to lint_markdown.sh. It seems most of our internal tooling follows a category-subcategory naming scheme.
util/exercise/src/main.rs
Outdated
| @@ -102,7 +102,7 @@ fn process_matches(matches: &ArgMatches<'_>) -> Result<()> { | |||
| } | |||
|
|
|||
| ("", None) => { | |||
| println!("No subcommand was used.\nUse init_exercise --help to learn about the possible subcommands."); | |||
| println!("No subcommand was used.\nUse exercise --help to learn about the possible subcommands."); | |||
There was a problem hiding this comment.
This change makes sense, but seems pretty unrelated to the rest of this PR.
There was a problem hiding this comment.
I agree. How do you feel about documenting something like a Unix philosophy for our pull requests?
Keep it small.
One logical change or something.
I can take a stab for #1111.
There was a problem hiding this comment.
Yeah, "one logical change" is the best expression of what I want to see in a PR. It's not necessarily small--there have been good, useful PRs which added hundreds of lines of code and took months to resolve (looking at you, #653)--but life is easier when PRs are focused.
ghost
changed the title
ghost
merged commit 
I was curious about what util/exercise and noticed the
Cargo.tomlhas trailing whitespace.So I took the opportunity to add a lint in CI too.
This is an example failure.