Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn 4 + ESLint 9 + PnP Support (3) #1506

Merged
merged 20 commits into from
Jul 30, 2024
Merged

Conversation

SleeplessByte
Copy link
Member

It keeps breaking on GH (probably the diff) so just recreating as that seems to trigger a working CI once.

  • Upgrade to Yarn 4, ESLint 9, and add PnP support
  • Upgrade SDKs
  • Sync
  • Format files
  • Fix .vscode files, upgrade all tests to new format
  • Update workflows to Node LTS @ 20
  • Fix lint issues
  • Remove babel transpilation for common actions
  • Simplify changed files check

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@SleeplessByte
Copy link
Member Author

(Please do not merge yet, test-runner needs to be updated first)

.prettierrc Outdated Show resolved Hide resolved
@ErikSchierboom
Copy link
Member

I'm sure you noticed, but please merge this with [no important files changed] in the commit message.

@SleeplessByte
Copy link
Member Author

@ErikSchierboom no let's rerun the tests on EVERY SINGLE SOLUTION :') /s

Technically [no important files changed] is even correct as none of the tests or content has changed.

@SleeplessByte SleeplessByte merged commit 4da603e into main Jul 30, 2024
9 checks passed
@SleeplessByte SleeplessByte deleted the feature/yarn4-eslint9-pnp-2 branch July 30, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/massive Massive amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants