This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Handler[T,R] should be newable/extendable in newer Scala.js #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83
A Scala.js-defined JS object cannot directly extend a native JS trait in:
-P:scalajs:sjsDefinedByDefault
optionCurrently,
Handler
extendsjs.Function3
, so users in such setup cannot extendHandler
or construct (new Handler {}
).This PR changes
Handler[TEvent, TResult]
into a Scala.js-defined trait.Note that
Handler
andAsyncHandler
is now clearly distinguished.so that it is newable/extendable