Style/MapIntoArray: Use map instead of each to map elements into an a…

…rray. (#214)
exoego · Apr 17, 2024 · 87fc7ea · 87fc7ea
1 parent 2efb549
commit 87fc7ea
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/lib/rspec/openapi/schema_builder.rb b/lib/rspec/openapi/schema_builder.rb
@@ -64,10 +64,8 @@ def example_enabled?
   end
 
   def build_parameters(record)
-    parameters = []
-
-    record.path_params.each do |key, value|
-      parameters << {
+    path_params = record.path_params.map do |key, value|
+      {
         name: build_parameter_name(key, value),
         in: 'path',
         required: true,
@@ -76,8 +74,8 @@ def build_parameters(record)
       }.compact
     end
 
-    record.query_params.each do |key, value|
-      parameters << {
+    query_params = record.query_params.map do |key, value|
+      {
         name: build_parameter_name(key, value),
         in: 'query',
         required: record.required_request_params.include?(key),
@@ -86,8 +84,8 @@ def build_parameters(record)
       }.compact
     end
 
-    record.request_headers.each do |key, value|
-      parameters << {
+    header_params = record.request_headers.map do |key, value|
+      {
         name: build_parameter_name(key, value),
         in: 'header',
         required: true,
@@ -96,6 +94,8 @@ def build_parameters(record)
       }.compact
     end
 
+    parameters = path_params + query_params + header_params
+
     return nil if parameters.empty?
 
     parameters