Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix float type #11

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Fix float type #11

merged 1 commit into from
Nov 13, 2020

Conversation

natsuokawai
Copy link
Contributor

@natsuokawai natsuokawai commented Nov 13, 2020

This PR fixes float type error by implementing build_format method for format keyword.

When you load a schema file including 'type: float' in Swagger Editor, structural error occurs.

スクリーンショット 2020-11-13 12 10 40

スクリーンショット 2020-11-13 12 10 46

In OAS3, float is not allowed for type and should be written as follows:

size:
  type: number
  format: float

https://swagger.io/docs/specification/data-models/data-types/

@k0kubun
Copy link
Collaborator

k0kubun commented Nov 13, 2020

Hmm, interesting. Thanks!

@k0kubun k0kubun merged commit f8854e6 into exoego:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants