Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow path-based config overrides #165

Merged
merged 9 commits into from
Jan 5, 2024
Merged

Allow path-based config overrides #165

merged 9 commits into from
Jan 5, 2024

Conversation

exoego
Copy link
Owner

@exoego exoego commented Jan 5, 2024

Based on #162 with some fixes

config_file = File.join(File.dirname(path), RSpec::OpenAPI.config_filename)
begin
require config_file if File.exist?(config_file)
rescue => e

Check notice

Code scanning / Rubocop

Avoid rescuing without specifying an error class. Note

Style/RescueStandardError: Avoid rescuing without specifying an error class.
@@ -0,0 +1,2 @@
RSpec::OpenAPI.title = 'Override title'

Check notice

Code scanning / Rubocop

Add the frozen_string_literal comment to the top of files to help transition to frozen string literals by default. Note documentation test

Style/FrozenStringLiteralComment: Missing frozen string literal comment.
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c1f6d52) 96.88% compared to head (f391238) 96.69%.

Files Patch % Lines
lib/rspec/openapi/result_recorder.rb 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   96.88%   96.69%   -0.19%     
==========================================
  Files          15       15              
  Lines         449      454       +5     
  Branches       96       97       +1     
==========================================
+ Hits          435      439       +4     
- Misses         14       15       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exoego exoego merged commit 71764c0 into master Jan 5, 2024
12 of 14 checks passed
@exoego exoego deleted the feat branch January 5, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants