Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @k0kubun.
I still have issues with an application with Rails engines... but it's tricky to create a spec for the case 😑
That's what I see:
0.47
) I get again "No route matched for ..." exception;find_rails_route
(but keeping the raise line) it gets better, but it still fails when there's a test on a non-existing path;I think that the iteration of the routes with the current code still returns
nil
in some situations (probably the linereturn find_rails_route(request, app: route.app.app, fix_path: false)
).Think about it, if you don't feel confident to merge a PR without a good test it's ok (in any case having an alternative here could help someone else perhaps).
Relates to #38 and #37