Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / Microsoft Entra Authentication #1242

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

thekevinbrown
Copy link
Member

@thekevinbrown thekevinbrown commented Oct 8, 2024

  • Adds support for Microsoft Entra auth. Support is implemented with JWT signature validation the same as Auth0 or any other auth provider.
  • Also adds support for the init-auth CLI command to read values from the graphweaver config file as import already does.

Note that MS doesn't give us JWTs which pass signature checks by default. You have to create a custom claim for MS to then give you a standards compliant JWT. More info on this is available in the readme for the Entra example.

…s in React specifically much.

Also fixed up the welcome page.
…very time but still feel like they're logging out.
…MSAL.

- Improve log out UX by ignoring specific MS errors that we know happen naturally as part of the logout process.
- Simplify logout call by removing a layer of async / await.
@thekevinbrown thekevinbrown merged commit f5bc9a4 into main Oct 8, 2024
14 checks passed
@thekevinbrown thekevinbrown deleted the feature/microsoft-entra-authentication branch October 8, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant