Feature / Microsoft Entra Authentication #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in React specifically much. Also fixed up the welcome page.
…very time but still feel like they're logging out.
…MSAL. - Improve log out UX by ignoring specific MS errors that we know happen naturally as part of the logout process. - Simplify logout call by removing a layer of async / await.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init-authCLI command to read values from the graphweaver config file asimportalready does.Note that MS doesn't give us JWTs which pass signature checks by default. You have to create a custom claim for MS to then give you a standards compliant JWT. More info on this is available in the readme for the Entra example.