Fix/related entities loading each in a separate query #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set common loader key so we can properly batch related entities and make one call to findByRelatedId with all the batched keys.
```
const loaderKey = `${gqlTypeName}-${relatedField}-${JSON.stringify(
filter
)}`; /* gqlTypeName-fieldname-filterObject */
```
👆 The above code causes the `loaderKey` to be unique for each related entity instead of having a common key.
```
const loaderKey = `${gqlTypeName}-${relatedField}`; /* gqlTypeName-fieldname */
```
This makes a common key per entity and field
thekevinbrown
changed the title
thekevinbrown
deleted the
fix/related-entities-loading-each-in-a-separate-querys
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dataloader was sometimes being used, but in effect bypassed because a unique loader was used for every iteration of the for loop when resolvers were running.
This PR fixes this issue and restores dataloader's behaviour, as well as changing the loading strategy for MikroORM so we can better filter the related entities when doing this type of fetch.