Generator: Add Custom Extension Findable #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre-Emmanuel Jacquier <15922119+pierre-emmanuelJ@users.noreply.github.com>
Signed-off-by: Pierre-Emmanuel Jacquier <15922119+pierre-emmanuelJ@users.noreply.github.com>
Signed-off-by: Pierre-Emmanuel Jacquier <15922119+pierre-emmanuelJ@users.noreply.github.com>
Signed-off-by: Pierre-Emmanuel Jacquier <15922119+pierre-emmanuelJ@users.noreply.github.com>
Signed-off-by: Pierre-Emmanuel Jacquier <15922119+pierre-emmanuelJ@users.noreply.github.com>
Signed-off-by: Pierre-Emmanuel Jacquier <15922119+pierre-emmanuelJ@users.noreply.github.com>
kobajagi
reviewed
Sep 11, 2024
Co-authored-by: Predrag Janosevic <predrag.janosevic@exoscale.com>
kobajagi
reviewed
Sep 11, 2024
kobajagi
reviewed
Sep 11, 2024
kobajagi
approved these changes
Sep 11, 2024
pierre-emmanuelJ
pushed a commit
that referenced
this pull request
Sep 12, 2024
# Description The update of the Go version to go1.23 forces all the users of the API client to upgrade to go1.23. A lib should avoid forcing to upgrade Go for compatibility reasons, especially in a bug fix. The update of Go is related to the update of `github.com/pb33f/libopenapi` to v0.18.0 inside the PR #656. `github.com/pb33f/libopenapi@v0.18.0` uses go1.23 because of the usage of the new `iter` package from go1.23 (pb33f/libopenapi#319). This is only related to the generator package, this package is not used by the users of the API client. So I created a dedicated module for the generator: the dependencies of the generator will be isolated inside this module, and will have no impact on the API client. This module doesn't need release, it's just a "local" module. The target `make generate` still works as before. This will not impact users who have already updated to go1.23. --- Side note: The usage of the vendoring for a lib is mainly useless because the vendor folder is not included inside the module distributed by the Go proxies. Also, Go proxies are here to ensure that a lib cannot disappear: if the GitHub repository is deleted, the Go proxies will still serve the module (even if it's a pseudo-version). So I recommend removing the vendor directories (at least for v3 and the generator).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From the spec findable
x-go-findable1and2it's building the custom findable we want.By default, it's remain
name 1andid 2but now you can for example givefor elastic-ip you can point:
1 - id2 - ipand findable will generate a findable func with
idOrIPparameter to be foundChecklist
(For exoscale contributors)