Add Existing CloudTrail Onboarding Functionality #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanmil
changed the title
jamesjuran2
approved these changes
Sep 7, 2022
sarjumulmi
reviewed
Sep 7, 2022
- Added SNS Topic entity to function as a one -> many subscription tool between S3 notification configuration to multiple interested parties (including Expel WB which subscribes via SQS Queue) - Added several local variables to help keep existing CloudTrail vs. new CloudTrail logic isolated from granular infrastructure configuration - Added existing CloudTrail example - Added a notification specific KMS key to be used separate from the CloudTrail & S3 Bucket KMS keys to simplify permissions when using an existing CloudTrail entity - Added comments to categorize groups of variables in variables.tf file - Removed providers from readme - Fixed generated doc check
ethanmil
force-pushed
the
existing-cloudtrail
branch
from
6f6f377
to
ee2a271
Compare
bachu20
approved these changes
Sep 8, 2022
…key or default to theirs
…ample default to null
bachu20
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Currently only accounts for hooking up all the necessary resources within THE SAME AWS account.
Added
one -> manysubscription tool between S3 notification configuration to multiple interested parties (including Expel WB which subscribes via SQS Queue)variables.tffileRemoved
Providersfrom readme as it was redundant withRequirementsFixed (internal)