Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEP-3359 Adding scantf and removing security scan #42

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

charcustodio-expel
Copy link

Adding scantf 1.5.0 and removing security scan

@charcustodio-expel
Copy link
Author

Hi @expel-io/turn-on-and-monitoring!

We upgraded tfsec image for scanning and there is a low vulnerability regarding enabling Cloudwatch logging.
https://app.circleci.com/pipelines/github/expel-io/terraform-aws-cloudtrail/239/workflows/83db3d87-d40f-4574-badd-31f1f0596ab7/jobs/624

Based on this information, let us know how you would like to proceed?

@ethanmil ethanmil requested a review from a team April 6, 2023 15:39
@sarjumulmi
Copy link
Contributor

Hi @expel-io/turn-on-and-monitoring!

We upgraded tfsec image for scanning and there is a low vulnerability regarding enabling Cloudwatch logging. https://app.circleci.com/pipelines/github/expel-io/terraform-aws-cloudtrail/239/workflows/83db3d87-d40f-4574-badd-31f1f0596ab7/jobs/624

Based on this information, let us know how you would like to proceed?

i think we don't want to enable it right now to maintain parity w/ other onboarding methods. I'll create a ticket in the backlog to look into it.

@charcustodio-expel charcustodio-expel marked this pull request as ready for review April 10, 2023 19:16
@charcustodio-expel charcustodio-expel merged commit 3902858 into main Apr 10, 2023
@charcustodio-expel charcustodio-expel deleted the CEP-3359-ReplaceOrb-TFScan branch April 10, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants