Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TME-2291: Update stackset expel principal arn #45

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

bachu20
Copy link
Contributor

@bachu20 bachu20 commented Jul 18, 2023

Updates the principal account arn to point directly to the Expel AWS account when establishing the trust relationship instead of going through the created IAM role as is currently being done.

This PR has been tested to validate that no regressions were introduced.

@intertwine
Copy link

Is the scan-tf check fail related to this change?

@bachu20
Copy link
Contributor Author

bachu20 commented Jul 18, 2023

Is the scan-tf check fail related to this change?

nope, I'm adding an ignore block to the relevant section so it doesn't break future PRs.

@bachu20 bachu20 force-pushed the tme-2291/terraform-config-updates branch from d20e285 to da727a5 Compare July 18, 2023 15:47
sarjumulmi
sarjumulmi previously approved these changes Jul 18, 2023
@bachu20 bachu20 merged commit 47b5dc2 into main Jul 18, 2023
@bachu20 bachu20 deleted the tme-2291/terraform-config-updates branch July 18, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants