-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TME-2684 - Add docs and contributing guidelines #56
Conversation
examples/existing-cloudtrail/cross-account/wip.terraform.tfvars
Outdated
Show resolved
Hide resolved
examples/existing-cloudtrail/single-account/wip.terraform.tfvars
Outdated
Show resolved
Hide resolved
Suggested documentation changes look amazing, thanks for the awesome work on this! 🔥 |
@bachu20 sounds good, thanks brother, it was definitely a learning experience! I'll bring it up during standup that this is ready to go, the only remaining issue is the contributing doc. I posted on the ticket what needs to be, or should be changed. |
@closb I'll create a separate task to address the security concerns noted by the scan-tf task. |
@bachu20 sounds good, thanks! |
I added doc comments and edited existing docs to adhere to best practices. I also added README in examples directory that provide a brief explanation of the setup and pertinent information.
The docs contain the recommended sections for open source documentation. Minus the structure, the edits to the context were minimal and mostly consisted of grammar for brevity and clarity.
I have added the
wip
prefix to files until we come to a consensus and agree on context and format.That said, the current contributing file is missing information and is a boilerplate which is taken directly from the contributors covenant known as the de-facto standard for open source projects.
I have also added context and references to the Jira ticket to explain the path I chose and reasons why.