Update: Adds support for specifying optional assume role #60
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarjumulmi
reviewed
Apr 24, 2024
| @@ -1,3 +1,9 @@ | |||
| locals { | |||
| provisioner_role_arn = var.assume_role_arn == null ? data.aws_caller_identity.current.arn : var.assume_role_arn | |||
| cloudtrail_key_policy_root = var.is_existing_cloudtrail_cross_account == false ? "arn:aws:iam::${local.customer_aws_account_id}:root" : "arn:aws:iam::${var.existing_cloudtrail_log_bucket_account_id}:root" | |||
There was a problem hiding this comment.
shouldn't this always be the cloudtrail account & not the log bucket account? probably the else part is never applied since we don't even create the cloudtrial key for existing cloudtrails?
There was a problem hiding this comment.
good point, I'll correct as a follow-on task but would rather not introduce new variables rn. I'll create a ticket to validate / remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for passing in an optional role arn argument for instances in which the module configuration is being applied via an assumed role.
aws_caller_identity.