Doe categorical #243
Merged
Doe categorical #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les and writing tests
… of column keys in dataframe
…ign/bofire into doe_categorical
dlinzner-bcs
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Looks fine to me! Thank you so much for all the great work @ufukguenes 💯
|
@dlinzner-bcs and @ufukguenes : have you seen that the pyright test was not passing when you merged the PR in? |
|
@jduerholt yes I saw that. I plan to clean it up asap. Is this critical? We wanted to have the additional functionality before ufuk left. |
|
Hmm, I am also a bit irritated that we still have additional feature types in, I thought that we agreed on not having additional ones ... |
|
Honestly, I would prefer to revert the merge and proper discuss it and see if we can do it without the addional features. |
ufukguenes
added a commit
that referenced
this pull request
Aug 11, 2023
This reverts commit 126393e.
dlinzner-bcs
pushed a commit
that referenced
this pull request
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at including categorical variables and discrete variables in DOE. Solving with exhaustive search and branch-and-bound