Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Priors from "Vanilla Bayesian Optimization Performs Great in High Dimensions" #402

Merged
merged 6 commits into from
Jun 10, 2024

Conversation

jduerholt
Copy link
Contributor

@jduerholt jduerholt commented Jun 6, 2024

This PR implements the dimensionality scaled priors from the paper "Vanilla Bayesian Optimization Performs Great in High Dimensions" from Hvarfner et al. (https://arxiv.org/pdf/2402.02229) This is also a nice blogpost regarding the method: https://www.miguelgondu.com/blogposts/2024-03-16/when-does-vanilla-gpr-fail/

Probably, I will set the prior also as new default.

@jduerholt jduerholt requested a review from bertiqwerty June 6, 2024 16:09
@bertiqwerty
Copy link
Contributor

bertiqwerty commented Jun 7, 2024

That's a great idea! I will have a look.

@jduerholt
Copy link
Contributor Author

Anything missing fore merging it in? Or do you need a bit more time for review?

Copy link
Contributor

@bertiqwerty bertiqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

bofire/data_models/priors/api.py Outdated Show resolved Hide resolved
@jduerholt jduerholt merged commit 22c83fa into main Jun 10, 2024
9 of 10 checks passed
@jduerholt jduerholt deleted the feature/dimensionality_prior branch June 10, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants