Merge pull request #26 from martijnvdkerkhof/patch-1

Remove use of warning suppression with @ symbol
experius · Sep 27, 2021 · a4afe6f · a4afe6f
2 parents d4fdfea + f82a70c
commit a4afe6f
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/Helper/Data.php b/Helper/Data.php
@@ -202,13 +202,23 @@ public function getFileName($locale = 'en_US', $requiredExists = true)
         $vendor = $this->getLanguageVendor();
         $directoryPath = $this->directoryList->getRoot() . '/app/i18n/' . $vendor . '/missing/';
         if (!is_dir($directoryPath)) {
-            @mkdir($directoryPath, 0777, true);
+            $mkdirResult = mkdir($directoryPath, 0777, true);
+            if (false === $mkdirResult) {
+                throw new \Magento\Framework\Exception\LocalizedException(
+                    new \Magento\Framework\Phrase('Failed to create directory %1', [$directoryPath])
+                );
+            }
         }
         // Fallback for e.g., Magento Cloud, where /app directory has no write access
         if (!is_dir($directoryPath)) {
             $directoryPath = $this->directoryList->getRoot() . '/var/i18n/' . $vendor . '/missing/';
             if (!is_dir($directoryPath)) {
-                @mkdir($directoryPath, 0777, true);
+                $mkdirResult = mkdir($directoryPath, 0777, true);
+                if (false === $mkdirResult) {
+                    throw new \Magento\Framework\Exception\LocalizedException(
+                        new \Magento\Framework\Phrase('Failed to create directory %1', [$directoryPath])
+                    );
+                }
             }
         }