[FEATURE] Js translation feature added and cronjobs are now configurable #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 22, 2018 10:49
…ion gathering cronjobs. Default is off, must be enabled to gather new translations on global scope every night.
…s function is triggered for all themes with a specific locale, on saving a translation in the missing translations section. This enables real-time updates of javascript translations for each locale active in a Magento 2 installation.
…on.json file on translation save. Deployed version number was not being updated resulting in translations not coming through in the frontend with all cache one (full_page).
|
@lewisvoncken , One more addition, checking if files exist and updating deployment version number. The latter was required for full production all cache enabled enviroments for the translations to come through to the frontend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Js translation feature has been added. Tested on Magento 2.2.2; where most core Magento 2 translation bugfixes are present.