set up dark mode and added sidebar #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickFoden
reviewed
Mar 26, 2021
| </Main> | ||
| {/* <Footer theme={theme} /> */} | ||
| </DocumentBody> | ||
| <ThemeProvider theme={darkTheme}> |
There was a problem hiding this comment.
I think we can set theme with the useState above, and then use state.theme here or such, but yeah lets merge and we can use this provider 👍 !
There was a problem hiding this comment.
Last week I set it with ThemeProvider and useState. It worked nicely. But it doesn't work anymore, I'll find out why
NickFoden
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
light mode & mode toggle are not working for some reason, I'll look into it
for now, I set dark mode and also added a sidebar