Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardcomponent #35

Merged
merged 9 commits into from
Jun 9, 2021
Merged

Cardcomponent #35

merged 9 commits into from
Jun 9, 2021

Conversation

anastasssia88
Copy link
Collaborator

No description provided.

Copy link
Member

@NickFoden NickFoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

Few comments/suggestions/musings, and then one request for the list of tags to use a key prop.

src/components/card/Card.js Outdated Show resolved Hide resolved
src/components/card/Bookmark.js Outdated Show resolved Hide resolved
src/pages/Home.js Show resolved Hide resolved
src/components/card/Card.js Outdated Show resolved Hide resolved
@NickFoden NickFoden merged commit 399f764 into main Jun 9, 2021
@NickFoden NickFoden deleted the cardcomponent branch June 9, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants