Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pie and line chart tabs to query result preview #481

Merged
merged 8 commits into from
Aug 31, 2022

Conversation

eeriksp
Copy link
Contributor

@eeriksp eeriksp commented Jul 27, 2022

No description provided.

requirements/optional.txt Outdated Show resolved Hide resolved
requirements/optional.txt Outdated Show resolved Hide resolved
explorer/views/utils.py Outdated Show resolved Hide resolved
eeriksp and others added 4 commits July 28, 2022 11:45
Co-authored-by: Mark Walker <theshow@gmail.com>
Co-authored-by: Mark Walker <theshow@gmail.com>
Co-authored-by: Mark Walker <theshow@gmail.com>
@eeriksp
Copy link
Contributor Author

eeriksp commented Aug 2, 2022

@marksweb, thank you for amendments, they have all been incorporated now.
Anything else you would like to change?

docs/features.rst Outdated Show resolved Hide resolved
Co-authored-by: Mark Walker <theshow@gmail.com>
@eeriksp eeriksp requested a review from marksweb August 16, 2022 20:08
@marksweb
Copy link
Collaborator

@eeriksp Just realised, this needs the setup.py updating to handle the optional dependencies added here.

There's a good example here; https://github.com/anymail/django-anymail/blob/main/setup.py#L62

At the moment we've got;

extras_require={
        "xls": [
            'xlsxwriter>=1.2.1'
        ]
    },

So this could go in with the feature name;

extras_require={
        "graphs": [
            'matplotlib<4',
            'seaborn<0.12'
        ]
        "xls": [
            'xlsxwriter>=1.2.1'
        ]
    },

@marksweb marksweb merged commit 69e601c into explorerhq:master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants