Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pivot export #517

Merged
merged 4 commits into from
Dec 23, 2022
Merged

Conversation

lawson89
Copy link
Contributor

Js plugin to export pivot table to excel

Issue #459

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2022

Codecov Report

Merging #517 (c973e1e) into master (d93746d) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
+ Coverage   96.49%   96.55%   +0.06%     
==========================================
  Files          42       52      +10     
  Lines        2196     2238      +42     
==========================================
+ Hits         2119     2161      +42     
  Misses         77       77              
Impacted Files Coverage Δ
explorer/migrations/0003_query_snapshot.py 100.00% <0.00%> (ø)
explorer/migrations/0004_querylog_duration.py 100.00% <0.00%> (ø)
explorer/migrations/0002_auto_20150501_1515.py 100.00% <0.00%> (ø)
explorer/migrations/0008_auto_20190308_1642.py 100.00% <0.00%> (ø)
explorer/migrations/0009_auto_20201009_0547.py 100.00% <0.00%> (ø)
explorer/migrations/0006_query_connection.py 100.00% <0.00%> (ø)
explorer/migrations/0007_querylog_connection.py 100.00% <0.00%> (ø)
explorer/migrations/0005_auto_20160105_2052.py 100.00% <0.00%> (ø)
explorer/migrations/0001_initial.py 100.00% <0.00%> (ø)
explorer/migrations/0010_sql_required.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lawson89
Copy link
Contributor Author

@marksweb well this works great but I guess the js library to convert to Excel has a vulnerability. Do you know any more modern ones?

Issue explorerhq#459

switch to sheetjs for pivot table export
Issue explorerhq#459

switch to sheetjs for pivot table export
@lawson89
Copy link
Contributor Author

@marksweb switched to sheetjs, this is ready for review now

@marksweb
Copy link
Collaborator

@lawson89 Great find! I started looking into that previous library, but didn't get as far as finding a secure one.

@marksweb marksweb merged commit b1d3997 into explorerhq:master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants