snowflake support and general expansion of user managed DB support #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #640
Additionally, supports an "extras" field on the userspace DatabaseConnection object, which allows for arbitrary additional connection params to get added. This allows engine-specific (or just more obscure) settings to get injected into the connection.
I also found some bugs in the connection stuff in general, and it's been cleaned up. The form styling is also better!
Lastly, when uploading a csv/json/etc, the resulting connection is highlighted in the resulting connection list, making it much clearer what happened.