Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename modules for consistency #11286

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Conversation

svlandeg
Copy link
Member

@svlandeg svlandeg commented Aug 9, 2022

Description

The entity_ruler and attribute_ruler components remain unchanged in their naming, but this PR updates their Python modules to the same, consistent name. In v4, this will break imports from the old entityruler.py and attributeruler.py that need to be rewritten to import from entity_ruler.py and attribute_ruler.py instead.

This change makes the code base more consistent with entity_linker, span_ruler etc, and makes the naming of the Python modules consistent with the camel casing of the class names.

Types of change

Python module refactoring

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added meta Meta topics, e.g. repo organisation and issue management 🔜 v4.0 Related to upcoming v4.0 feat / spanruler Feature: Entity and span ruler labels Aug 9, 2022
@adrianeboyd
Copy link
Contributor

This is pleasingly minimal.

@adrianeboyd adrianeboyd merged commit 5d54c0e into explosion:v4 Aug 10, 2022
@svlandeg svlandeg deleted the rename_components branch August 10, 2022 09:51
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request Mar 14, 2024
* rename Python module to entity_ruler

* rename Python module to attribute_ruler
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request Mar 14, 2024
* rename Python module to entity_ruler

* rename Python module to attribute_ruler
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request Mar 29, 2024
* rename Python module to entity_ruler

* rename Python module to attribute_ruler
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request Apr 17, 2024
* rename Python module to entity_ruler

* rename Python module to attribute_ruler
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request Apr 17, 2024
* rename Python module to entity_ruler

* rename Python module to attribute_ruler
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request May 3, 2024
* rename Python module to entity_ruler

* rename Python module to attribute_ruler
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request May 10, 2024
* rename Python module to entity_ruler

* rename Python module to attribute_ruler
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request May 10, 2024
* rename Python module to entity_ruler

* rename Python module to attribute_ruler
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request May 10, 2024
* rename Python module to entity_ruler

* rename Python module to attribute_ruler
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request May 10, 2024
* rename Python module to entity_ruler

* rename Python module to attribute_ruler
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request May 21, 2024
* rename Python module to entity_ruler

* rename Python module to attribute_ruler
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request May 21, 2024
* rename Python module to entity_ruler

* rename Python module to attribute_ruler
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request May 21, 2024
* rename Python module to entity_ruler

* rename Python module to attribute_ruler
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request May 21, 2024
* rename Python module to entity_ruler

* rename Python module to attribute_ruler
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request May 21, 2024
* rename Python module to entity_ruler

* rename Python module to attribute_ruler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat / spanruler Feature: Entity and span ruler meta Meta topics, e.g. repo organisation and issue management 🔜 v4.0 Related to upcoming v4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants