Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise Typer limit #11720

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Raise Typer limit #11720

merged 2 commits into from
Nov 7, 2022

Conversation

polm
Copy link
Contributor

@polm polm commented Oct 31, 2022

Description

This raises the maximum version limit for Typer, as requested in #11708, in order to run the tests. Note that even if the tests succeed there may be other things not check or other reasons to not raise the limit. In particular, we need to check if anything was deprecated or changed significantly in 0.5.0 or later. Looking at the release notes this doesn't seem to be an issue.

Types of change

dependency update

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@polm polm added the third-party Third-party packages and services label Oct 31, 2022
@polm polm linked an issue Oct 31, 2022 that may be closed by this pull request
Is it possible to loosen the upper-bound constraint on Typer? #11708
Closed
@adrianeboyd
Copy link
Contributor

From the release notes it doesn't look like there are any breaking changes and the extra CI CLI tests cover most of the CLI commands.

@BLKSerene
Copy link
Contributor

BLKSerene commented Nov 6, 2022 •
edited
Loading

Hi, Typer 0.7.0 has been released, is it possible to further raise the version limit?

@polm
Copy link
Contributor Author

polm commented Nov 7, 2022

Went ahead and bumped requirements. Based on the release notes for the latest one, it also looks like there's nothing to worry about here.

@polm polm changed the title Raise Typer limit to <0.7.0 Raise Typer limit Nov 7, 2022
@adrianeboyd adrianeboyd merged commit b76222e into explosion:master Nov 7, 2022
adrianeboyd pushed a commit to adrianeboyd/spaCy that referenced this pull request Nov 7, 2022
@polm @adrianeboyd
Raise Typer limit (explosion#11720)
8fc74a7 
* Raise typer limit to <0.7.0

* Raise limit to <0.8.0
adrianeboyd pushed a commit to adrianeboyd/spaCy that referenced this pull request Nov 15, 2022
@polm @adrianeboyd
Raise Typer limit (explosion#11720)
38e5f48 
* Raise typer limit to <0.7.0

* Raise limit to <0.8.0
@skupr-anaconda skupr-anaconda mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
third-party Third-party packages and services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is it possible to loosen the upper-bound constraint on Typer?
3 participants
@polm @adrianeboyd @BLKSerene