Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added spacy-langdetect to universe.json #3266

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Conversation

Abhijit-2592
Copy link

Description

Added spacy-langdetect plugin to universe.json

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@explosion-bot
Copy link
Collaborator

Hi @Abhijit-2592, thanks for your pull request! 👍 It looks like you haven't filled in the spaCy Contributor Agreement (SCA) yet. The agrement ensures that we can use your contribution across the project. Once you've filled in the template, put it in the .github/contributors directory and add it to this pull request. If your pull request targets a branch that's not master, for example develop, make sure to submit the Contributor Agreement to the master branch. Thanks a lot!

If you've already included the Contributor Agreement in your pull request above, you can ignore this message.

@ines ines added the docs Documentation and website label Feb 12, 2019
@ines
Copy link
Member

ines commented Feb 12, 2019

Thanks! No idea why the test failed, looks like a problem with Travis. Since it's only docs changes, I'm happy to merge this 👍

@ines ines merged commit 75a40f5 into explosion:master Feb 12, 2019
@Abhijit-2592
Copy link
Author

@ines Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation and website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants