Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all existing MyPy errors and enable MyPy in CI #42

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Fix all existing MyPy errors and enable MyPy in CI #42

merged 2 commits into from
Mar 7, 2023

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Mar 3, 2023 •
edited
Loading

Fix MyPy issues and enable MyPy in CI.

@danieldk danieldk added the bug Something isn't working label Mar 3, 2023
@danieldk danieldk marked this pull request as draft March 5, 2023 16:49
@danieldk
Fixup some more issues in span_finder
3961aa2 
For some reason these didn't show up with my locally installed
MyPy version.
@danieldk danieldk marked this pull request as ready for review March 7, 2023 12:01
svlandeg
svlandeg approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! That all looks good to me.

@svlandeg svlandeg merged commit 6abf5bb into explosion:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieldk @svlandeg